Change in coreboot[master]: security/tpm: Add option to init TPM in bootblock

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51923 )

Change subject: security/tpm: Add option to init TPM in bootblock
......................................................................

Patch Set 7:

(1 comment)

File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/c/coreboot/+/51923/comment/caf2f535_7a61d885 
PS7, Line 187:  && !CONFIG(TPM_MEASURED_BOOT_INIT_BOOTBLOCK)
> Actually, is it a good idea to put that here? Most of the time when INIT_BOOTBLOCK is selected, the cache should be empty here anyway, so this is a no-op. But when it's not empty that means the bootblock loaded some other file before it got to the TPM init part (which is possible, for example, if hooks like bootblock_soc_init() load something). In that case, wouldn't you also want that measured? Otherwise the TCPA log doesn't match the PCR anymore.

Good call indeed. Thanks, I'll fix it