Attention is currently required from: Patrick Rudolph. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61455 )
Change subject: soc/intel/cannonlake: Drop unnecessary guard for Heci1 disable UPD ......................................................................
soc/intel/cannonlake: Drop unnecessary guard for Heci1 disable UPD
Add ability to disable Heci1 using FSP `Heci1Disabled` UPD.
BUG=none TEST=Boot to OS, verify if Heci1 is disabled on hatch system using FSP when mainboard selects DISABLE_HECI1_AT_PRE_BOOT config.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ia8908c080ca9991e7a71e795ccb8fc76d99514f8 --- M src/soc/intel/cannonlake/fsp_params.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/61455/1
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c index af356d1..9a8a5ac 100644 --- a/src/soc/intel/cannonlake/fsp_params.c +++ b/src/soc/intel/cannonlake/fsp_params.c @@ -586,9 +586,8 @@ params->ScsUfsEnabled = is_devfn_enabled(PCH_DEVFN_UFS);
params->Heci3Enabled = is_devfn_enabled(PCH_DEVFN_CSE_3); -#if !CONFIG(HECI_DISABLE_USING_SMM) + /* Allow FSP to disable Heci1 */ params->Heci1Disabled = CONFIG(DISABLE_HECI1_AT_PRE_BOOT); -#endif params->Device4Enable = config->Device4Enable;
/* Teton Glacier hybrid storage support */