Change in ...coreboot[master]: mb/google/sarien: Set system type for the board variants

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31207

Change subject: mb/google/sarien: Set system type for the board variants
......................................................................

mb/google/sarien: Set system type for the board variants

Select the appropriate system type for the different variants of
the Sarien board.

This will allow the Arcada variant to use the tablet mode feature
of the Intel Virtual Button driver.

Change-Id: I8a829aab012256ec196c8ec0fa298fd2bc77f2e1
Signed-off-by: Duncan Laurie 
---
M src/mainboard/google/sarien/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/31207/1

diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig
index 67f879f..785c8a7 100644
--- a/src/mainboard/google/sarien/Kconfig
+++ b/src/mainboard/google/sarien/Kconfig
@@ -21,7 +21,8 @@
    select SOC_INTEL_COMMON_BLOCK_HDA_VERB
    select SOC_INTEL_COMMON_BLOCK_SMM_ESPI_ACPI_DIS
    select SPD_READ_BY_WORD
-	select SYSTEM_TYPE_LAPTOP
+	select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_SARIEN
+	select SYSTEM_TYPE_CONVERTIBLE if BOARD_GOOGLE_ARCADA
    select TPM2
    select MAINBOARD_USES_IFD_EC_REGION
    select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_SARIEN

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31207 )

Change subject: mb/google/sarien: Set system type for the board variants
......................................................................

Patch Set 4: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31207 )

Change subject: mb/google/sarien: Set system type for the board variants
......................................................................

Patch Set 6: Code-Review+1

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31207 )

Change subject: mb/google/sarien: Set system type for the board variants
......................................................................

mb/google/sarien: Set system type for the board variants

Select the appropriate system type for the different variants of
the Sarien board.

This will allow the Arcada variant to use the tablet mode feature
of the Intel Virtual Button driver.

Change-Id: I8a829aab012256ec196c8ec0fa298fd2bc77f2e1
Signed-off-by: Duncan Laurie 
Reviewed-on: https://review.coreboot.org/c/31207
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/sarien/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig
index c6a9988..1216f2d 100644
--- a/src/mainboard/google/sarien/Kconfig
+++ b/src/mainboard/google/sarien/Kconfig
@@ -20,7 +20,8 @@
    select SOC_INTEL_COMMON_BLOCK_HDA_VERB
    select SOC_INTEL_COMMON_BLOCK_SMM_ESPI_ACPI_DIS
    select SPD_READ_BY_WORD
-	select SYSTEM_TYPE_LAPTOP
+	select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_SARIEN
+	select SYSTEM_TYPE_CONVERTIBLE if BOARD_GOOGLE_ARCADA
    select TPM2
    select MAINBOARD_USES_IFD_EC_REGION
    select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_SARIEN