Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42812 )
Change subject: soc/intel/common: Add a minimal PCI driver for IPU ......................................................................
soc/intel/common: Add a minimal PCI driver for IPU
Add a minimal PCI driver for Intel's IPU, this allows devices to be added underneath it in the devicetree.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I531b293634a5d40112dc6af7b33fedb5e13f35e5 --- A src/soc/intel/common/block/ipu/Kconfig A src/soc/intel/common/block/ipu/Makefile.inc A src/soc/intel/common/block/ipu/ipu.c 3 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/42812/1
diff --git a/src/soc/intel/common/block/ipu/Kconfig b/src/soc/intel/common/block/ipu/Kconfig new file mode 100644 index 0000000..756616f --- /dev/null +++ b/src/soc/intel/common/block/ipu/Kconfig @@ -0,0 +1,4 @@ +config SOC_INTEL_COMMON_BLOCK_IPU + bool + help + Intel Image Processing Unit driver diff --git a/src/soc/intel/common/block/ipu/Makefile.inc b/src/soc/intel/common/block/ipu/Makefile.inc new file mode 100644 index 0000000..ac5bc76 --- /dev/null +++ b/src/soc/intel/common/block/ipu/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_IPU) += ipu.c diff --git a/src/soc/intel/common/block/ipu/ipu.c b/src/soc/intel/common/block/ipu/ipu.c new file mode 100644 index 0000000..f7b01aa --- /dev/null +++ b/src/soc/intel/common/block/ipu/ipu.c @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <device/pci.h> +#include <device/pci_ids.h> + +struct device_operations ipu_pci_ops = { + .read_resources = pci_bus_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_bus_enable_resources, + .scan_bus = scan_generic_bus, + .ops_pci = &pci_dev_ops_pci, +}; + +static const uint16_t pci_device_ids[] = { + PCI_DEVICE_ID_INTEL_TGL_IPU, + PCI_DEVICE_ID_INTEL_JSL_IPU, +}; + +static const struct pci_driver intel_ipu __pci_driver = { + .ops = &ipu_pci_ops, + .vendor = PCI_VENDOR_ID_INTEL, + .devices = pci_device_ids, +};
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42812 )
Change subject: soc/intel/common: Add a minimal PCI driver for IPU ......................................................................
Patch Set 1:
Sugnan, you could rebase your last 1 or 2 patches on top of these so that you can add the mipi_camera chip driver underneath the IPU
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42812 )
Change subject: soc/intel/common: Add a minimal PCI driver for IPU ......................................................................
Patch Set 1:
Thanks Tim, I will rebase on top these patches and test the changes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42812 )
Change subject: soc/intel/common: Add a minimal PCI driver for IPU ......................................................................
Patch Set 1: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42812 )
Change subject: soc/intel/common: Add a minimal PCI driver for IPU ......................................................................
Patch Set 3: Code-Review+1
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42812 )
Change subject: soc/intel/common: Add a minimal PCI driver for IPU ......................................................................
soc/intel/common: Add a minimal PCI driver for IPU
Add a minimal PCI driver for Intel's IPU, this allows devices to be added underneath it in the devicetree.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I531b293634a5d40112dc6af7b33fedb5e13f35e5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42812 Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/soc/intel/common/block/ipu/Kconfig A src/soc/intel/common/block/ipu/Makefile.inc A src/soc/intel/common/block/ipu/ipu.c 3 files changed, 28 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Rizwan Qureshi: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Christian Walter: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/ipu/Kconfig b/src/soc/intel/common/block/ipu/Kconfig new file mode 100644 index 0000000..756616f --- /dev/null +++ b/src/soc/intel/common/block/ipu/Kconfig @@ -0,0 +1,4 @@ +config SOC_INTEL_COMMON_BLOCK_IPU + bool + help + Intel Image Processing Unit driver diff --git a/src/soc/intel/common/block/ipu/Makefile.inc b/src/soc/intel/common/block/ipu/Makefile.inc new file mode 100644 index 0000000..ac5bc76 --- /dev/null +++ b/src/soc/intel/common/block/ipu/Makefile.inc @@ -0,0 +1 @@ +ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_IPU) += ipu.c diff --git a/src/soc/intel/common/block/ipu/ipu.c b/src/soc/intel/common/block/ipu/ipu.c new file mode 100644 index 0000000..f7b01aa --- /dev/null +++ b/src/soc/intel/common/block/ipu/ipu.c @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <device/pci.h> +#include <device/pci_ids.h> + +struct device_operations ipu_pci_ops = { + .read_resources = pci_bus_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_bus_enable_resources, + .scan_bus = scan_generic_bus, + .ops_pci = &pci_dev_ops_pci, +}; + +static const uint16_t pci_device_ids[] = { + PCI_DEVICE_ID_INTEL_TGL_IPU, + PCI_DEVICE_ID_INTEL_JSL_IPU, +}; + +static const struct pci_driver intel_ipu __pci_driver = { + .ops = &ipu_pci_ops, + .vendor = PCI_VENDOR_ID_INTEL, + .devices = pci_device_ids, +};
-
Christian Walter (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Sugnan Prabhu S (Code Review)
-
Tim Wawrzynczak (Code Review)