Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, ritul guru.
Martin Roth has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83740?usp=email )
Change subject: soc/amd/common/psp_smi: implement P2C mailbox handling
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Patchset:
PS4:
i'd like to keep this in this folder, since it belongs thematically to the other files in there and […]
Hrmph. I disagree, but it's your decision.
File src/soc/amd/common/block/psp/psp_smi.c:
https://review.coreboot.org/c/coreboot/+/83740/comment/e9ca93ee_d3617959?usp... :
PS4, Line 80: u32
the existing parts of the psp code in coreboot already use a mix of both; i can look into using only […]
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83740?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I50479bed2332addae652026c6818460eeb6403af
Gerrit-Change-Number: 83740
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Aug 2024 17:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de