Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68490 )
Change subject: mb/google/geralt: Configure firmware display for eDP panel
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/geralt/display.h:
https://review.coreboot.org/c/coreboot/+/68490/comment/9d25fa6d_16311717
PS5, Line 8: bool
If there's no good reason, please use `int` as the return type.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67e0699c976c6f85e69d40d77154420c983b715e
Gerrit-Change-Number: 68490
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 03:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment