Attention is currently required from: Arthur Heymans, Eric Lai, Paul Menzel, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )
Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config
......................................................................
Patch Set 9:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/75756/comment/60fdc679_7017af21 :
PS9, Line 226: /* skip old type for save static memory
: "Other",
: "Unknown",
: "DRAM",
: "EDRAM",
: "VRAM",
: "SRAM",
: "RAM",
: "ROM",
: "Flash",
: "EEPROM",
: "FEPROM",
: "EPROM",
: "CDRAM",
: "3DRAM",
: "SDRAM",
: "SGRAM",
: "RDRAM",
: "DDR",
: "DDR2",
: "DDR2 FB-DIMM",
: "Reserved",
: "Reserved",
: "Reserved",
: "DDR3",
: "FBD2",
: */
Is printing SMBIOS information for older DRAM specs not desirable? It will print unsupported type, which is incorrect.
+2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b5ca1f4a59598531a6cba500672c2717f2a7b00
Gerrit-Change-Number: 75756
Gerrit-PatchSet: 9
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 10:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment