Attention is currently required from: Felix Singer.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83107?usp=email )
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard ......................................................................
Patch Set 15:
(13 comments)
Patchset:
PS4:
Remove the execute bit from all files.
Done
Patchset:
PS15: Thanks!
File src/mainboard/asrock/imb-1222/Kconfig:
PS3:
Add SPDX license identifier header
Done
File src/mainboard/asrock/imb-1222/Kconfig.name:
PS3:
Add SPDX license identifier header
Done
File src/mainboard/asrock/imb-1222/Makefile.inc:
PS3:
Rename to Makefile. […]
Done
File src/mainboard/asrock/imb-1222/devicetree.cb:
PS3:
Add SPDX license identifier header
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/53b7d6ad_15b75a76?usp... : PS3, Line 61: pci 00.0
Use the device alias names from the chipset devicetree.
Done
File src/mainboard/asrock/imb-1222/gpio.c:
https://review.coreboot.org/c/coreboot/+/83107/comment/137b110c_55551853?usp... : PS3, Line 27: PAD_NC(GPP_A17, NONE), /* GPIO */
Please remove comments from pads which are unused.
Done
File src/mainboard/asrock/imb-1222/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/83107/comment/9fe3b39b_a011cf99?usp... : PS3, Line 11: AZALIA_PIN_CFG(0, 0x12, 0x411111f0),
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/e4feaef8_4271bf14?usp... : PS3, Line 14: AZALIA_PIN_CFG(0, 0x16, 0x411111f0), : A
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/e54b6ec4_6d25623d?usp... : PS3, Line 18: 0x411111f0
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/4497beef_f00db3b4?usp... : PS3, Line 20: 0x411111f0
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/960ce2e2_a5547457?usp... : PS3, Line 23: 0x411111f0
Done