[XS] Change in coreboot[master]: acpi/acpigen.c: Be explicit about char sign - coreboot-gerrit

29 Jun 2023


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76006?usp=email )
Change subject: acpi/acpigen.c: Be explicit about char sign
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76006/comment/a406455e_5f2d88aa :
PS1, Line 9: is architecture
           : dependent
...
huh, i didn't expect this to be the case
Undefined behavior in C is sometimes in the news :-) : https://www.phoronix.com/news/Linux-6.2-funsigned-char . Maybe it's worth fixing it like the kernel to unravel bugs.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53b99835b2ffec5d752fc531fd59e4715f61aced
Gerrit-Change-Number: 76006
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Thu, 29 Jun 2023 17:56:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment