Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36039 )
Change subject: nb/intel/nehalem: Only enable_smbus once ......................................................................
nb/intel/nehalem: Only enable_smbus once
This is already done in nb/intel/nehalem/romstage.c.
Change-Id: I2dc34af874ac96af31ca9ebe6a43b2805da32d18 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/36039/1
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index c887de1..1fca4c4 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -3766,9 +3766,6 @@
collect_system_info(&info);
- /* Enable SMBUS. */ - enable_smbus(); - memset(&info.populated_ranks, 0, sizeof(info.populated_ranks));
info.use_ecc = 1;
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36039 )
Change subject: nb/intel/nehalem: Only enable_smbus once ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36039 )
Change subject: nb/intel/nehalem: Only enable_smbus once ......................................................................
nb/intel/nehalem: Only enable_smbus once
This is already done in nb/intel/nehalem/romstage.c.
Change-Id: I2dc34af874ac96af31ca9ebe6a43b2805da32d18 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36039 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index c887de1..1fca4c4 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -3766,9 +3766,6 @@
collect_system_info(&info);
- /* Enable SMBUS. */ - enable_smbus(); - memset(&info.populated_ranks, 0, sizeof(info.populated_ranks));
info.use_ecc = 1;
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)