HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46213 )
Change subject: mb/pcengines/apu2: Convert to ASL 2.0 syntax ......................................................................
mb/pcengines/apu2: Convert to ASL 2.0 syntax
Change-Id: Ie2b1b27c0715fc223e644c3df6c0e9cb876322c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/pcengines/apu2/acpi/sleep.asl 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46213/1
diff --git a/src/mainboard/pcengines/apu2/acpi/sleep.asl b/src/mainboard/pcengines/apu2/acpi/sleep.asl index 39fe610..377f0de 100644 --- a/src/mainboard/pcengines/apu2/acpi/sleep.asl +++ b/src/mainboard/pcengines/apu2/acpi/sleep.asl @@ -30,9 +30,9 @@ /* DBGO("\n") */
/* Clear wake status structure. */ - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) - Store(7, UPWS) + WKST [0] = 0 + WKST [1] = 0 + UPWS = 7 _SB.APTS(Arg0) } /* End Method(_PTS) */
@@ -58,7 +58,7 @@ /* DBGO(" to S0\n") */
/* clear USB wake up signal */ - Store(1, USBS) + USBS = 1
_SB.AWAK(Arg0)
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46213 )
Change subject: mb/pcengines/apu2: Convert to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46213 )
Change subject: mb/pcengines/apu2: Convert to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46213 )
Change subject: mb/pcengines/apu2: Convert to ASL 2.0 syntax ......................................................................
mb/pcengines/apu2: Convert to ASL 2.0 syntax
Change-Id: Ie2b1b27c0715fc223e644c3df6c0e9cb876322c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46213 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/mainboard/pcengines/apu2/acpi/sleep.asl 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Michał Żygowski: Looks good to me, approved
diff --git a/src/mainboard/pcengines/apu2/acpi/sleep.asl b/src/mainboard/pcengines/apu2/acpi/sleep.asl index 39fe610..377f0de 100644 --- a/src/mainboard/pcengines/apu2/acpi/sleep.asl +++ b/src/mainboard/pcengines/apu2/acpi/sleep.asl @@ -30,9 +30,9 @@ /* DBGO("\n") */
/* Clear wake status structure. */ - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) - Store(7, UPWS) + WKST [0] = 0 + WKST [1] = 0 + UPWS = 7 _SB.APTS(Arg0) } /* End Method(_PTS) */
@@ -58,7 +58,7 @@ /* DBGO(" to S0\n") */
/* clear USB wake up signal */ - Store(1, USBS) + USBS = 1
_SB.AWAK(Arg0)
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Michał Żygowski (Code Review)
-
Patrick Georgi (Code Review)