Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ......................................................................
Patch Set 17:
(3 comments)
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/ac4d05cd_f0d7aae6?usp... : PS17, Line 62: "Wrong array size for mt6363_sdmadc_chan_specs");
`please, no spaces at the start of a line`
Please fix.
https://review.coreboot.org/c/coreboot/+/85128/comment/4cf04482_840ec653?usp... : PS17, Line 62: "Wrong array size for mt6363_sdmadc_chan_specs");
`code indent should use tabs where possible`
Please fix.
https://review.coreboot.org/c/coreboot/+/85128/comment/71d42617_6aa32af3?usp... : PS17, Line 76: Add ``` mt6363_init_pmif_arb(); ```
BTW, does it required `mt6363_init()` to be called before reading ADC value ?