Attention is currently required from: Bob Moragues, Bob Moragues, Karthik Ramasubramanian, Kenneth Chan, Paul Menzel, Shelley Chen, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84689?usp=email )
Change subject: mb/google/brox/jubilant: Modify WWAN Rolling RW101R-GL power sequence
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84689/comment/64aa7168_b01a5f60?usp... :
PS4, Line 9: mdule
module
fixed.
https://review.coreboot.org/c/coreboot/+/84689/comment/db17037a_26d587d3?usp... :
PS4, Line 9: There is no ACPI power resource for LTE mdule Rolling RW101R-GL
Could such a resource be added?
Maybe it's a log term solution.
https://review.coreboot.org/c/coreboot/+/84689/comment/4f8eec5e_790380cf?usp... :
PS4, Line 10: power off
Ditto.
fixed.
https://review.coreboot.org/c/coreboot/+/84689/comment/5445b469_9528e22f?usp... :
PS4, Line 10: power on
As it is *not* used as a verb here: poweron or power-on.
fixed.
https://review.coreboot.org/c/coreboot/+/84689/comment/c03537fc_1ff4aa6b?usp... :
PS4, Line 13:
What sources did you use to implement this?
For the power sequence, we have to control the related pins:
WWAN_PWR_EN
WWAN_FPCO#
WWAN_RESET#
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a205e3db777c7c225d31b6cc802883fd7167089
Gerrit-Change-Number: 84689
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Bob Moragues
moragues@chromium.org
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 16 Oct 2024 07:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org