Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22214 )
Change subject: nb/intel/sandybridge/raminit: Add ECC detection support ......................................................................
Patch Set 12: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/22214/12/src/northbridge/intel/sand... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/22214/12/src/northbridge/intel/sand... PS12, Line 309: /* Get ECC support and mode */ Why isn't this inside try_init_dram_ddr3 or something similar?
https://review.coreboot.org/c/coreboot/+/22214/12/src/northbridge/intel/sand... PS12, Line 311: ctrl.ecc_forced || This should not be needed
https://review.coreboot.org/c/coreboot/+/22214/12/src/northbridge/intel/sand... File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/c/coreboot/+/22214/12/src/northbridge/intel/sand... PS12, Line 135: bool ecc_supported; See the warning at the top of this struct