Jon Murphy has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85461?usp=email )
Change subject: ec/google/chromeec: Define ACPI_NOTIFY_CROS_EC_MKBP constant ......................................................................
ec/google/chromeec: Define ACPI_NOTIFY_CROS_EC_MKBP constant
This change simply replaces 0x80 with a top level constant called ACPI_NOTIFY_CROS_EC_MKBP. There are no functional changes.
BUG=b:343288326 TEST=Build
Change-Id: Ia476263620acc269f9dd8a6b3c9e5e247b403aee Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85461 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Boris Mittelberg bmbm@google.com --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Boris Mittelberg: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Caveh Jalali: Looks good to me, approved
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 741ad59..f04ce6a 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -12,6 +12,7 @@ #define EC_OEM_VARIABLE_DATA_MASK 0x7 #define INT3400_ODVP_CHANGED 0x88
+#define ACPI_NOTIFY_CROS_EC_MKBP 0x80 #define ACPI_NOTIFY_CROS_EC_PANIC 0xB0
// Mainboard specific throttle handler @@ -437,7 +438,7 @@ Method (_Q1B, 0, NotSerialized) { Printf ("EC: MKBP") - Notify (CREC, 0x80) + Notify (CREC, ACPI_NOTIFY_CROS_EC_MKBP) }
#ifdef EC_ENABLE_PD_MCU_DEVICE