Eric Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63098 )
Change subject: mb/google/nissa/var/nivviks: Remove USB2 WWAN ......................................................................
mb/google/nissa/var/nivviks: Remove USB2 WWAN
FM101-GL is USB3 WWAN. Thus, remove the USB2 WWAN node.
BUG=b:223490884 TEST=FM101-GL work as expected. localhost ~ # lsusb Bus 004 Device 002: ID 2cb7:01a2 Fibocom Wireless Inc. Fibocom FM101-GL Module localhost ~ # lsusb -t /: Bus 04.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 10000M |__ Port 2: Dev 2, If 0, Class=Communications, Driver=cdc_mbim, 5000M |__ Port 2: Dev 2, If 1, Class=CDC Data, Driver=cdc_mbim, 5000M |__ Port 2: Dev 2, If 2, Class=Vendor Specific Class, Driver=option, 5000M |__ Port 2: Dev 2, If 3, Class=Vendor Specific Class, Driver=option, 5000M |__ Port 2: Dev 2, If 4, Class=Vendor Specific Class, Driver=option, 5000M |__ Port 2: Dev 2, If 5, Class=Vendor Specific Class, Driver=option, 5000M
Signed-off-by: Eric Lai eric_lai@quanta.corp-partner.google.com Change-Id: I9d37ef7104afd2d4c218fb1f4e1d493ccdbffdb2 --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 5 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/63098/1
diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index c870b37..9249896 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -302,18 +302,6 @@ end end chip drivers/usb/acpi - register "desc" = ""USB2 WWAN"" - register "type" = "UPC_TYPE_INTERNAL" - register "has_power_resource" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F12)" - register "reset_off_delay_ms" = "20" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" - register "enable_delay_ms" = "20" - device ref usb2_port4 on - probe DB_USB DB_1C_LTE - end - end - chip drivers/usb/acpi register "desc" = ""USB2 Camera"" register "type" = "UPC_TYPE_INTERNAL" device ref usb2_port6 on end @@ -342,6 +330,11 @@ chip drivers/usb/acpi register "desc" = ""USB3 WWAN"" register "type" = "UPC_TYPE_INTERNAL" + register "has_power_resource" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F12)" + register "reset_off_delay_ms" = "20" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "enable_delay_ms" = "20" device ref usb3_port2 on probe DB_USB DB_1C_LTE end