Change in coreboot[master]: soc/intel/elkhartlake: Drop unreferenced devicetree settings

[Angel Pons (Code Review)]

Hello  Felix Singer, V Sowmya, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48568

to review the following change.

Change subject: soc/intel/elkhartlake: Drop unreferenced devicetree settings
......................................................................

soc/intel/elkhartlake: Drop unreferenced devicetree settings

No mainboard uses these settings, nor does SoC code. Drop them.

Change-Id: Ia928c4bbddd1c160228a9af8faf5d4be787f73f8
Signed-off-by: Angel Pons 
---
M src/soc/intel/elkhartlake/chip.h
1 file changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48568/1

diff --git a/src/soc/intel/elkhartlake/chip.h b/src/soc/intel/elkhartlake/chip.h
index 7cd29b4..37237bb 100644
--- a/src/soc/intel/elkhartlake/chip.h
+++ b/src/soc/intel/elkhartlake/chip.h
@@ -132,17 +132,9 @@
    /* Enable if SD Card Power Enable Signal is Active High */
    uint8_t SdCardPowerEnableActiveHigh;

-	/* Integrated Sensor */
-	uint8_t PchIshEnable;
-
-	/* Heci related */
-	uint8_t Heci3Enabled;
-
    /* Gfx related */
-	uint8_t IgdDvmt50PreAlloc;
    uint8_t SkipExtGfxScan;

-	uint32_t GraphicsConfigPtr;
    uint8_t Device4Enable;

/* HeciEnabled decides the state of Heci1 at end of boot

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48568 )

Change subject: soc/intel/elkhartlake: Drop unreferenced devicetree settings
......................................................................

Patch Set 1: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48568 )

Change subject: soc/intel/elkhartlake: Drop unreferenced devicetree settings
......................................................................

Patch Set 1: Code-Review+2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48568 )

Change subject: soc/intel/elkhartlake: Drop unreferenced devicetree settings
......................................................................

soc/intel/elkhartlake: Drop unreferenced devicetree settings

No mainboard uses these settings, nor does SoC code. Drop them.

Change-Id: Ia928c4bbddd1c160228a9af8faf5d4be787f73f8
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48568
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Michael Niewöhner 
---
M src/soc/intel/elkhartlake/chip.h
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/soc/intel/elkhartlake/chip.h b/src/soc/intel/elkhartlake/chip.h
index 7cd29b4..37237bb 100644
--- a/src/soc/intel/elkhartlake/chip.h
+++ b/src/soc/intel/elkhartlake/chip.h
@@ -132,17 +132,9 @@
    /* Enable if SD Card Power Enable Signal is Active High */
    uint8_t SdCardPowerEnableActiveHigh;

-	/* Integrated Sensor */
-	uint8_t PchIshEnable;
-
-	/* Heci related */
-	uint8_t Heci3Enabled;
-
    /* Gfx related */
-	uint8_t IgdDvmt50PreAlloc;
    uint8_t SkipExtGfxScan;

-	uint32_t GraphicsConfigPtr;
    uint8_t Device4Enable;

/* HeciEnabled decides the state of Heci1 at end of boot