Attention is currently required from: Jakub Czapiga, Yu-Ping Wu.
Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83765?usp=email )
Change subject: lib/string: Add strncat() and strcat() functions ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
I'll leave it for now because of the license issue (don't have time to re-write the inefficient libp […]
Right, but since you're writing these functions from scratch anyway, you could just upload them as BSD code right now. If you upload them like this they'll be GPL and that would make it complicated again to potentially merge things later.
Maybe at least start something in commonlib with these two functions (doesn't mean you have to port everything else right away too)?
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/83765/comment/32bbdd4a_30fbed06?usp... : PS4, Line 119: strcpy(dst + strlen(dst), src); Same applies here, obviously (same code as above just without the `count--` check).