Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68139
to look at the new patch set (#3).
Change subject: soc/amd/mendocino: Enable GPP clk req disabling for disabled devices
......................................................................
soc/amd/mendocino: Enable GPP clk req disabling for disabled devices
This commit enables GPP clk req disabling for disabled PCIe devices.
Having clk req enabled when the PCIe device is actually disabled may
interfere with the SoC suspending.
BUG=b:250009974
TEST=Ran on skyrim proto device, verified that clk reqs are set
appropriately
Change-Id: I6c840f2fa3f9358f58c0386134d23511ff880248
Signed-off-by: Robert Zieba robertzieba@google.com
---
M src/mainboard/amd/chausie/Makefile.inc
M src/mainboard/google/skyrim/Makefile.inc
M src/soc/amd/mendocino/Kconfig
M src/soc/amd/mendocino/chip.h
M src/soc/amd/mendocino/fch.c
5 files changed, 26 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/68139/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c840f2fa3f9358f58c0386134d23511ff880248
Gerrit-Change-Number: 68139
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset