Attention is currently required from: Daniel Peng, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/85363?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/glassway: Modify touch screen ILIT2901 sequence
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85363/comment/fc1639f3_47fb6709?usp... :
PS4, Line 10: touchscreen specification
Done
I do not see it.
https://review.coreboot.org/c/coreboot/+/85363/comment/928d97a1_ce7ec847?usp... :
PS4, Line 11: which delay calibration timing
Done
Sorry, I still do not understand item 1. What are you requesting from the vendor exactly?
https://review.coreboot.org/c/coreboot/+/85363/comment/abcad2a3_8aa9d9a4?usp... :
PS4, Line 12: Change
My suggestion is:
- Double delay RST time to 12 ms
https://review.coreboot.org/c/coreboot/+/85363/comment/70efa2fe_d499dd53?usp... :
PS4, Line 14:
Each firmware of panel might be specific requirement for the project. […]
Please add it to the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85363?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15e30ee72541b4f12b3ec4ea509cb09dc29659ca
Gerrit-Change-Number: 85363
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Dec 2024 08:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com