Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57361 )
Change subject: smbios.c: Rename two local functions ......................................................................
smbios.c: Rename two local functions
Rename two functions that have `walk` in their name but do not perform any walk. The new names are derived from the comments just above these functions' definitions. Also, remove these now-redundant comments.
Change-Id: I380a5b60b3f4e820e8f6d6f960826de97c0446be Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/smbios.c 1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/57361/1
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 0af149e..2625cb6 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -1130,9 +1130,8 @@ } }
-/* Generate Type41 entries from devicetree */ -static int smbios_walk_device_tree_type41(struct device *dev, int *handle, - unsigned long *current) +static int smbios_generate_type41_from_devtree(struct device *dev, int *handle, + unsigned long *current) { static u8 type41_inst_cnt[SMBIOS_DEVICE_TYPE_COUNT + 1] = {};
@@ -1162,9 +1161,8 @@ device_type); }
-/* Generate Type9 entries from devicetree */ -static int smbios_walk_device_tree_type9(struct device *dev, int *handle, - unsigned long *current) +static int smbios_generate_type9_from_devtree(struct device *dev, int *handle, + unsigned long *current) { enum misc_slot_usage usage; enum slot_data_bus_bandwidth bandwidth; @@ -1223,8 +1221,8 @@ printk(BIOS_INFO, "%s (%s)\n", dev_path(dev), dev_name(dev)); len += dev->ops->get_smbios_data(dev, handle, current); } - len += smbios_walk_device_tree_type9(dev, handle, current); - len += smbios_walk_device_tree_type41(dev, handle, current); + len += smbios_generate_type9_from_devtree(dev, handle, current); + len += smbios_generate_type41_from_devtree(dev, handle, current); } return len; }