Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62649 )
Change subject: mb/prodrive/hermes: Allow using the Intel iGPU as primary
......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/62649/comment/cabc7cb7_7eed5969
PS1, Line 262: internale_gfx
There's a typo, and enum type is unused anyway. […]
Done
https://review.coreboot.org/c/coreboot/+/62649/comment/365601d3_b4767b0e
PS1, Line 280: mainboard_configure_internal_gfx
Why not call this from `mainboard_early()`?
To answer myself: the right place to call this from is when entering BS_DEV_RESOURCES.
https://review.coreboot.org/c/coreboot/+/62649/comment/60de5580_19077bbe
PS1, Line 283: board_cfg
This can be NULL.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24d9ebc2055dc246e7f257aa2f3853b22c8af370
Gerrit-Change-Number: 62649
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 06 Sep 2022 19:10:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment