Attention is currently required from: Nicholas Sudsgaard.
Matt DeVillier has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/84414?usp=email )
Change subject: mb/google: Correct number of jacks in hda_verb.c ......................................................................
Patch Set 4: Code-Review+2
(4 comments)
Patchset:
PS4: tested on LINK under Linux and Win11, audio working properly under both
File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/84414/comment/b4f902ee_9efe6f53?usp... : PS4, Line 9: 16, // Number of jacks (NID entries) would prefer to keep this in hex for consistency / like all other variants
File src/mainboard/google/link/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/84414/comment/29efc01e_ff42720d?usp... : PS4, Line 9: 21, // Number of jacks + Number of Malcolm setup blocks. would prefer to keep this in hex for consistency
https://review.coreboot.org/c/coreboot/+/84414/comment/67e8b101_9b4d95c1?usp... : PS4, Line 65: AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ : AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ : AZALIA_VERB_12B(0x0, 0x10, 0x78d, 0x2), /* Padding */ this fixes the processing of the 2nd verb below (#3) per cbmem log
-
Matt DeVillier (Code Review)