Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Scott Chao, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60126 )
Change subject: soc/intel/alderlake: do not lock GPP_B16/ GPP_B17 ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60126/comment/a91b40f0_ee08a9ef PS2, Line 7: do not lock GPP_B16/ GPP_B17 Please remove the space after the slash (/).
https://review.coreboot.org/c/coreboot/+/60126/comment/5cbb726b_13e20f5e PS2, Line 9: Do not lock GPP_B16/ GPP_B17 because we set it as NF2. This will let i2c device lost function after warm reboot. Please wrap lines after 72 characters.
https://review.coreboot.org/c/coreboot/+/60126/comment/186c202e_627d69a6 PS2, Line 9: This will let i2c device lost function after warm reboot. Maybe:
This causes the I2C touchpad device to stop working after warm reboot.
https://review.coreboot.org/c/coreboot/+/60126/comment/9914efd9_c2c08060 PS2, Line 13: work works
-
Paul Menzel (Code Review)