Change in coreboot[master]: soc/intel/common: Retry END_OF_POST command - coreboot-gerrit

20 Mar 2022


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62192 )
Change subject: soc/intel/common: Retry END_OF_POST command
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/62192/comment/48580af0_0e57e090 
PS12, Line 14: #define CSE_MAX_RETRY_CMD	3
...
sorry, I didn't notice the comment. […]
IMO it's just unnecessary indirection. Others might have a different opinion
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683
Gerrit-Change-Number: 62192
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla sridhar.nest@gmail.com
Gerrit-Comment-Date: Sun, 20 Mar 2022 18:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla sridhar.siricilla@intel.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment