Change in ...coreboot[master]: libpayload: Don't try to use invalid row count - coreboot-gerrit

6 Dec 2018


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30092 )
Change subject: libpayload: Don't try to use invalid row count
......................................................................
Patch Set 1:
Are you sure this is the right fix? I'd argue that a console with 0 rows is an illegal console anyway, so either corebootfb_init() should return -1 if the rows (or columns) it calculates are 0, or video_init() should double-check that after calling init() before hooking up a new console.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30092
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib022d3c6fc0c9cf360809dca28761a50c787304a
Gerrit-Change-Number: 30092
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 06 Dec 2018 23:46:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment