Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60002 )
Change subject: mb/google/corsola: setup open-drain ChromeOS pins ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60002/comment/4d2728ca_18a7febf PS2, Line 10: GPIO_SAR_INT_ODL/GPIO_BT_WAKE_AP_ODL/GPIO_WIFI_INT_ODL : GPIO_DPBRDG_INT_ODL/GPIO_EDPBRDG_INT_ODL/GPIO_EC_AP_HPD_OD : GPIO_TCHPAD_INT_ODL/GPIO_TCHSCR_INT_1V8_ODL/GPIO_EC_AP_INT_ODL : GPIO_EC_IN_RW_ODL/GPIO_GSC_AP_INT_ODL/GPIO_AP_WP_ODL : GPIO_HP_INT_ODL/GPIO_PEN_EJECT_OD/GPIO_UCAM_DET_ODL I think you don't need to list all the GPIOs (already in the code); instead you can describe what's fixed after you configured all these GPIOs correctly (for example TPM?).