[XS] Change in coreboot[master]: mb/google/myst: Update PCIE_RST_L drive - coreboot-gerrit

9 Jun 2023


      Attention is currently required from: Jon Murphy.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75700?usp=email )
Change subject: mb/google/myst: Update PCIE_RST_L drive
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75700/comment/a67ce8ec_944b2f69 :
PS2, Line 55: 	PAD_NF(GPIO_27, PCIE_RST1_L, PULL_NONE),
...
NF is interned change? If so, better mention in comment.
maybe also give the reason why in romstage is output here is NF.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75700?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f7a548a33eb18327139f033d7c0d6a1843f1639
Gerrit-Change-Number: 75700
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 23:59:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment