Attention is currently required from: CoolStar, Martin Roth, Stefan Reinauer.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )
Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1:
This is a brand new I2C driver that is designed specifically for the Pixel 2013 chromebook (LINK). […]
I would copy/paste this entire comment into the commit msg
File src/mainboard/google/link/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/76159/comment/f8acdc66_570c5228 : PS1, Line 14: // Trackpad Wake is GPIO12 : Name(_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x03 } ) : what do ppl think about commenting out and adding a note as to why vs removing?
https://review.coreboot.org/c/coreboot/+/76159/comment/62034983_28cb5ce9 : PS1, Line 38: / Touchscreen Wake is GPIO14 : Name(_PRW, Package(){0x1e, 0x03}) : same as above
File src/mainboard/google/link/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/76159/comment/71215639_d91cc53f : PS1, Line 36: #include "acpi/mainboard.asl" add a comment here to note the change in ordering was to ensure that we scope _SB.PCI0.GFX after the device is declared in the GMA asl