[XS] Change in coreboot[master]: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86 - coreboot-gerrit

30 Jun 2023


      Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Lance Zhao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email )
Change subject: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76070/comment/a11d89e5_b8dfea91 :
PS1, Line 161: 	if (ENV_X86)
...
We already have arch_fill_fadt(), I think it has worked out pretty well so perhaps introduce arch_fi […]
+1 to `arch_fill_madt()`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335
Gerrit-Change-Number: 76070
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 30 Jun 2023 14:06:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak inforichland@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment