Change in coreboot[master]: soc/mediatek/mt8192: fix impedance tracking channel number

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Yidi Lin (Code Review)

14 Oct 2020 14 Oct '20

11:26 a.m.

Hello Xi Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46399

to review the following change.

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

soc/mediatek/mt8192: fix impedance tracking channel number

Update impedance tracking CH1 setting.

Signed-off-by: mtk11206 xixi.chen@mediatek.com Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 --- M src/soc/mediatek/mt8192/dramc_tracking.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46399/1

diff --git a/src/soc/mediatek/mt8192/dramc_tracking.c b/src/soc/mediatek/mt8192/dramc_tracking.c old mode 100644 new mode 100755 index 3b0b8d6..382675e --- a/src/soc/mediatek/mt8192/dramc_tracking.c +++ b/src/soc/mediatek/mt8192/dramc_tracking.c @@ -526,7 +526,7 @@ MISC_IMPCAL_DIS_SUS_CH1_DRV, 1, MISC_IMPCAL_IMPSRCEXT, 0, MISC_IMPCAL_IMPCAL_ECO_OPT, 1); - SET32_BITFIELDS(&ch[0].phy_ao.misc_impcal, + SET32_BITFIELDS(&ch[1].phy_ao.misc_impcal, MISC_IMPCAL_DIS_SUS_CH0_DRV, 1, MISC_IMPCAL_DIS_SUS_CH1_DRV, 0, MISC_IMPCAL_IMPSRCEXT, 1,

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Hung-Te Lin (Code Review)

14 Oct 14 Oct

1:54 p.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46399 )

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

Patch Set 1:

can you simply amend this to CB:44724? given 44724 hasn't been merged, I see no reason to push a change that is known to have bugs.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-Comment-Date: Wed, 14 Oct 2020 13:54:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Xi Chen (Code Review)

15 Oct 15 Oct

2:40 a.m.

Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46399 )

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

Patch Set 1:

...

Patch Set 1:

can you simply amend this to CB:44724? given 44724 hasn't been merged, I see no reason to push a change that is known to have bugs.

yes, i will amend the change to 44724.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-Comment-Date: Thu, 15 Oct 2020 02:40:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

16 Oct 16 Oct

2:29 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46399 )

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46399/4/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_tracking.c:

https://review.coreboot.org/c/coreboot/+/46399/4/src/soc/mediatek/mt8192/dra... PS4, Line 529: SET32_BITFIELDS(&ch[1].phy_ao.misc_impcal, Can this be squashed into the commit under review?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 16 Oct 2020 14:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

18 Nov 18 Nov

9:29 a.m.

Hello Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46399

to look at the new patch set (#22).

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

soc/mediatek/mt8192: fix impedance tracking channel number

Update impedance tracking CH1 setting.

Signed-off-by: mtk11206 xixi.chen@mediatek.com Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 --- M src/soc/mediatek/mt8192/dramc_tracking.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46399/22

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 22 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

2 Dec 2 Dec

9:56 a.m.

Hello Hung-Te Lin, Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46399

to look at the new patch set (#32).

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

soc/mediatek/mt8192: fix impedance tracking channel number

Update impedance tracking CH1 setting.

Signed-off-by: mtk11206 xixi.chen@mediatek.com Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 --- M src/soc/mediatek/mt8192/dramc_tracking.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46399/32

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 32 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

4 Dec 4 Dec

4:21 a.m.

Hello Hung-Te Lin, Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46399

to look at the new patch set (#34).

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

soc/mediatek/mt8192: fix impedance tracking channel number

Update impedance tracking CH1 setting.

Signed-off-by: mtk11206 xixi.chen@mediatek.com Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 --- M src/soc/mediatek/mt8192/dramc_tracking.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46399/34

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 34 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

30 Dec 30 Dec

8:20 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46399 )

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

Patch Set 38:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46399/38//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46399/38//COMMIT_MSG@2 PS38, Line 2: mtk11206 Can you please configure *Xi Chen*?

git config --global user.name "Xi Chen"

git commit -s --amend --author="Xi Chen xixi.chen@mediatek.com"

https://review.coreboot.org/c/coreboot/+/46399/38//COMMIT_MSG@11 PS38, Line 11: mtk11206 Ditto.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 38 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 30 Dec 2020 08:20:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

11 Mar 11 Mar

9:14 a.m.

Attention is currently required from: Yidi Lin. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46399 )

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

Patch Set 45:

(1 comment)

Patchset:

PS45: abandon this?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 45 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Thu, 11 Mar 2021 09:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

9:20 a.m.

Yidi Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46399 )

Change subject: soc/mediatek/mt8192: fix impedance tracking channel number ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/46399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8 Gerrit-Change-Number: 46399 Gerrit-PatchSet: 45 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1359

days inactive

1507

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Hung-Te Lin (Code Review)
Paul Menzel (Code Review)
Xi Chen (Code Review)
Yidi Lin (Code Review)