Attention is currently required from: Jakub Czapiga, Yu-Ping Wu.
Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83765?usp=email )
Change subject: commonlib/bsd: Add strncat() and strcat() functions ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/83765/comment/80ef7441_b6dd47ed?usp... : PS4, Line 119: strcpy(dst + strlen(dst), src);
Because `strcpy` references `strlen`, I moved `strlen` to commonlib/bsd in CB:83830. […]
Yeah, sorry, you're right. I was completely off-track here and didn't think about the problem closely enough.
There are many string functions where calling `strlen()` internally creates performance issues (some particularly bad ones in libpayload, e.g. `strcpy()` and `strncpy()`), but this isn't one of them.
-
Julius Werner (Code Review)