Sam Lewis has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
mb/ti/beaglebone: Rename beaglebone to beaglebone-black
Retargets the Beaglebone port to be a Beaglebone Black port. The original Beaglebone (sometimes referred to as the Beaglebone White) has been mostly superseded by the Beaglebone Black and is no longer available for purchase.
This port currently is unfinished, so it makes sense to retarget it towards available hardware. The original Beaglebone and Beaglebone Black are very similar in any case (biggest material difference is 256MB of RAM in the original vs. 512MB in the Black) so, if there were interest, it probably would not be very difficult to get the port to work on the original Beaglebone.
Change-Id: Ied0632badf19c20b37411375f0bce652453aef6e Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com --- R src/mainboard/ti/beaglebone-black/Kconfig A src/mainboard/ti/beaglebone-black/Kconfig.name R src/mainboard/ti/beaglebone-black/Makefile.inc R src/mainboard/ti/beaglebone-black/board_info.txt R src/mainboard/ti/beaglebone-black/bootblock.c R src/mainboard/ti/beaglebone-black/devicetree.cb R src/mainboard/ti/beaglebone-black/leds.c R src/mainboard/ti/beaglebone-black/leds.h R src/mainboard/ti/beaglebone-black/romstage.c D src/mainboard/ti/beaglebone/Kconfig.name 10 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/44379/1
diff --git a/src/mainboard/ti/beaglebone/Kconfig b/src/mainboard/ti/beaglebone-black/Kconfig similarity index 73% rename from src/mainboard/ti/beaglebone/Kconfig rename to src/mainboard/ti/beaglebone-black/Kconfig index 5be310c..5ff844e 100644 --- a/src/mainboard/ti/beaglebone/Kconfig +++ b/src/mainboard/ti/beaglebone-black/Kconfig @@ -1,6 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-only
-if BOARD_TI_BEAGLEBONE +if BOARD_TI_BEAGLEBONE_BLACK
config BOARD_SPECIFIC_OPTIONS def_bool y @@ -10,11 +10,11 @@
config MAINBOARD_DIR string - default "ti/beaglebone" + default "ti/beaglebone-black"
config MAINBOARD_PART_NUMBER string - default "Beaglebone" + default "Beaglebone Black"
config MAX_CPUS int @@ -28,4 +28,4 @@ int default 0
-endif # BOARD_TI_BEAGLEBONE +endif # BOARD_TI_BEAGLEBONE_BLACK diff --git a/src/mainboard/ti/beaglebone-black/Kconfig.name b/src/mainboard/ti/beaglebone-black/Kconfig.name new file mode 100644 index 0000000..a7757b5 --- /dev/null +++ b/src/mainboard/ti/beaglebone-black/Kconfig.name @@ -0,0 +1,2 @@ +config BOARD_TI_BEAGLEBONE_BLACK + bool "Beaglebone Black" diff --git a/src/mainboard/ti/beaglebone/Makefile.inc b/src/mainboard/ti/beaglebone-black/Makefile.inc similarity index 100% rename from src/mainboard/ti/beaglebone/Makefile.inc rename to src/mainboard/ti/beaglebone-black/Makefile.inc diff --git a/src/mainboard/ti/beaglebone/board_info.txt b/src/mainboard/ti/beaglebone-black/board_info.txt similarity index 100% rename from src/mainboard/ti/beaglebone/board_info.txt rename to src/mainboard/ti/beaglebone-black/board_info.txt diff --git a/src/mainboard/ti/beaglebone/bootblock.c b/src/mainboard/ti/beaglebone-black/bootblock.c similarity index 100% rename from src/mainboard/ti/beaglebone/bootblock.c rename to src/mainboard/ti/beaglebone-black/bootblock.c diff --git a/src/mainboard/ti/beaglebone/devicetree.cb b/src/mainboard/ti/beaglebone-black/devicetree.cb similarity index 100% rename from src/mainboard/ti/beaglebone/devicetree.cb rename to src/mainboard/ti/beaglebone-black/devicetree.cb diff --git a/src/mainboard/ti/beaglebone/leds.c b/src/mainboard/ti/beaglebone-black/leds.c similarity index 100% rename from src/mainboard/ti/beaglebone/leds.c rename to src/mainboard/ti/beaglebone-black/leds.c diff --git a/src/mainboard/ti/beaglebone/leds.h b/src/mainboard/ti/beaglebone-black/leds.h similarity index 100% rename from src/mainboard/ti/beaglebone/leds.h rename to src/mainboard/ti/beaglebone-black/leds.h diff --git a/src/mainboard/ti/beaglebone/romstage.c b/src/mainboard/ti/beaglebone-black/romstage.c similarity index 100% rename from src/mainboard/ti/beaglebone/romstage.c rename to src/mainboard/ti/beaglebone-black/romstage.c diff --git a/src/mainboard/ti/beaglebone/Kconfig.name b/src/mainboard/ti/beaglebone/Kconfig.name deleted file mode 100644 index f03759e..0000000 --- a/src/mainboard/ti/beaglebone/Kconfig.name +++ /dev/null @@ -1,2 +0,0 @@ -config BOARD_TI_BEAGLEBONE - bool "Beaglebone"
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44379
to look at the new patch set (#2).
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
mb/ti/beaglebone: Rename beaglebone to beaglebone-black
Retargets the Beaglebone port to be a Beaglebone Black port. The original Beaglebone (sometimes referred to as the Beaglebone White) has been mostly superseded by the Beaglebone Black and is no longer available for purchase.
This port currently is unfinished, so it makes sense to retarget it towards available hardware. The original Beaglebone and Beaglebone Black are very similar in any case (biggest material difference is 256MB of RAM in the original vs. 512MB in the Black) so, if there were interest, it probably would not be very difficult to get the port to work on the original Beaglebone.
Change-Id: Ied0632badf19c20b37411375f0bce652453aef6e Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com --- R src/mainboard/ti/beaglebone-black/Kconfig A src/mainboard/ti/beaglebone-black/Kconfig.name R src/mainboard/ti/beaglebone-black/Makefile.inc R src/mainboard/ti/beaglebone-black/board_info.txt R src/mainboard/ti/beaglebone-black/bootblock.c R src/mainboard/ti/beaglebone-black/devicetree.cb R src/mainboard/ti/beaglebone-black/leds.c R src/mainboard/ti/beaglebone-black/leds.h R src/mainboard/ti/beaglebone-black/romstage.c D src/mainboard/ti/beaglebone/Kconfig.name 10 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/44379/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44379/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44379/5//COMMIT_MSG@9 PS5, Line 9: Retargets Retarget
https://review.coreboot.org/c/coreboot/+/44379/5//COMMIT_MSG@14 PS5, Line 14: currently is is currently
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44379
to look at the new patch set (#6).
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
mb/ti/beaglebone: Rename beaglebone to beaglebone-black
Retarget the Beaglebone port to be a Beaglebone Black port. The original Beaglebone (sometimes referred to as the Beaglebone White) has been mostly superseded by the Beaglebone Black and is no longer available for purchase.
This port is currently unfinished, so it makes sense to retarget it towards available hardware. The original Beaglebone and Beaglebone Black are very similar in any case (biggest material difference is 256MB of RAM in the original vs. 512MB in the Black) so, if there were interest, it probably would not be very difficult to get the port to work on the original Beaglebone.
Change-Id: Ied0632badf19c20b37411375f0bce652453aef6e Signed-off-by: Sam Lewis sam.vr.lewis@gmail.com --- R src/mainboard/ti/beaglebone-black/Kconfig A src/mainboard/ti/beaglebone-black/Kconfig.name R src/mainboard/ti/beaglebone-black/Makefile.inc R src/mainboard/ti/beaglebone-black/board_info.txt R src/mainboard/ti/beaglebone-black/bootblock.c R src/mainboard/ti/beaglebone-black/devicetree.cb R src/mainboard/ti/beaglebone-black/leds.c R src/mainboard/ti/beaglebone-black/leds.h R src/mainboard/ti/beaglebone-black/romstage.c D src/mainboard/ti/beaglebone/Kconfig.name 10 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/44379/6
Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44379/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44379/5//COMMIT_MSG@9 PS5, Line 9: Retargets
Retarget
Done
https://review.coreboot.org/c/coreboot/+/44379/5//COMMIT_MSG@14 PS5, Line 14: currently is
is currently
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG@19 PS8, Line 19: original Beaglebone. I wonder if the right course of action isn't to add the "black" as a variant then?
Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG@19 PS8, Line 19: original Beaglebone.
I wonder if the right course of action isn't to add the "black" as a variant then?
Hmm, I'm not sure, given I don't have an original Beaglebone to test with. If we were to have a variant for the original Beaglebone then I think it'd mean either:
1) I do my best to adapt this BBB port to the original Beaglebone, but I won't be able to test it. They are similar enough that it should mostly work, but the SDRAM stuff will be a bit of a guessing game. Or, 2) The original Beaglebone variant is kept in its previous state in the tree, and someone can come along and finish the port if they'd like to in the future.
Given that this port sat in the tree for quite some years without being completely functional (I think it hasn't even booted for a few years now), I feel like there hasn't been a lot of demand for a coreboot port of original Beaglebone. And given that it's hard to acquire an original Beaglebone in 2020, it seems like that is probably unlikely to change in the future. :) I'm hopeful that this, more complete, BBB port will have a little more interest but only time will tell!
What do you think?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG@19 PS8, Line 19: original Beaglebone.
Hmm, I'm not sure, given I don't have an original Beaglebone to test with. […]
Even if you rip out the "white" support, maybe it's still good to create the structure of a "global" beaglebone baseboard and a black variant, if just for naming: beaglebone-black/variants/white feels a bit weird ;-)
So just define ti/beaglebone as-is to support beaglebone black. If anybody ever comes up with -white support, it's up to them to make white a variant of that?
Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44379/8//COMMIT_MSG@19 PS8, Line 19: original Beaglebone.
Even if you rip out the "white" support, maybe it's still good to create the structure of a "global" […]
Ah, sorry, I think I misunderstood what you were saying before - I get what you mean now.
Yes, that sounds like a nice plan, agree that beaglebone-black/variants/white is weird! My only worry is that someone won't necessarily know which beaglebone is supported if they're looking at boards/ti/beaglebone for the first time. That said, I have some documentation in this patch train that makes it explicit that it's for the black so hopefully that's enough to make it clear.
I'll drop this patch so that it stays as is, with ti/beaglebone.
Sam Lewis has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44379 )
Change subject: mb/ti/beaglebone: Rename beaglebone to beaglebone-black ......................................................................
Abandoned
Sticking with the tree as it was (mb/ti/beaglebone) based on discussion in the review.
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Sam Lewis (Code Review)