Change in coreboot[master]: include/stdint.h: Remove old refrence to ROMCC

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

22 Feb 2020 22 Feb '20

9:24 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39072 )

Change subject: include/stdint.h: Remove old refrence to ROMCC ......................................................................

include/stdint.h: Remove old refrence to ROMCC

Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/stdint.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/39072/1

diff --git a/src/include/stdint.h b/src/include/stdint.h index b534add..3c9cdec 100644 --- a/src/include/stdint.h +++ b/src/include/stdint.h @@ -14,9 +14,9 @@ #ifndef STDINT_H #define STDINT_H

-/* romcc does not support long long, _Static_assert, or _Bool, so we must ifdef that code out. - Also, GCC can provide its own implementation of stdint.h, so in theory we could use that - instead of this custom file once romcc is no more. */ +/* TODO: GCC can provide its own implementation of stdint.h, + * so in theory we could use that + */

/* Fixed width integer types */ typedef signed char int8_t;

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

HAOUAS Elyes (Code Review)

23 Feb 23 Feb

9:06 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39072

to look at the new patch set (#2).

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

include/stdint.h: Remove old reference to ROMCC

Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/stdint.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/39072/2

Jacob Garber (Code Review)

25 Feb 25 Feb

12:05 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39072 )

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39072/2/src/include/stdint.h File src/include/stdint.h:

https://review.coreboot.org/c/coreboot/+/39072/2/src/include/stdint.h@17 PS2, Line 17: /* TODO: GCC can provide its own implementation of stdint.h, I think this whole comment can be removed. We rely in several places on the exact integer types used here, and switching to the GCC header would loose that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Gerrit-Change-Number: 39072 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-Comment-Date: Tue, 25 Feb 2020 00:05:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:54 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39072 )

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

Patch Set 2:

(1 comment)

Thx

https://review.coreboot.org/c/coreboot/+/39072/2/src/include/stdint.h File src/include/stdint.h:

https://review.coreboot.org/c/coreboot/+/39072/2/src/include/stdint.h@17 PS2, Line 17: /* TODO: GCC can provide its own implementation of stdint.h,

...

I think this whole comment can be removed. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Gerrit-Change-Number: 39072 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-Comment-Date: Tue, 25 Feb 2020 04:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:57 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39072

to look at the new patch set (#3).

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

include/stdint.h: Remove old reference to ROMCC

Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/stdint.h 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/39072/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Gerrit-Change-Number: 39072 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: newpatchset

Jacob Garber (Code Review)

5:28 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39072 )

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Gerrit-Change-Number: 39072 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 25 Feb 2020 05:28:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:17 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39072 )

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

include/stdint.h: Remove old reference to ROMCC

Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39072 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jacob Garber jgarber1@ualberta.ca --- M src/include/stdint.h 1 file changed, 0 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Jacob Garber: Looks good to me, approved

diff --git a/src/include/stdint.h b/src/include/stdint.h index b534add..b3e4cb3 100644 --- a/src/include/stdint.h +++ b/src/include/stdint.h @@ -14,10 +14,6 @@ #ifndef STDINT_H #define STDINT_H

-/* romcc does not support long long, _Static_assert, or _Bool, so we must ifdef that code out. - Also, GCC can provide its own implementation of stdint.h, so in theory we could use that - instead of this custom file once romcc is no more. */ - /* Fixed width integer types */ typedef signed char int8_t; typedef unsigned char uint8_t;

-- To view, visit https://review.coreboot.org/c/coreboot/+/39072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Gerrit-Change-Number: 39072 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

10:53 a.m.

New subject: Change in coreboot[master]: include/stdint.h: Remove old reference to ROMCC

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39072 )

Change subject: include/stdint.h: Remove old reference to ROMCC ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/860 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/859 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/858

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/39072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00fdcee177c5d4b5e95bc3d0330fd8934eee2f0a Gerrit-Change-Number: 39072 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 25 Feb 2020 10:53:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1545

days inactive

1548

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
HAOUAS Elyes (Code Review)
Jacob Garber (Code Review)
Patrick Georgi (Code Review)