Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nicholas Sudsgaard.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80695/comment/94d2e0be_558bb3f7 :
PS5, Line 60: AZALIA_LOCATION_UNKNOWN
Would something like AZALIA_LOCATION_NOT_APPLICABLE make more
sense here? In the mainboard code, an 'unknown' might look like
the developer didn't know what to set.
Or maybe, without looking too close, could we remove the whole value
after the merge locations patch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80695?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e
Gerrit-Change-Number: 80695
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sun, 25 Feb 2024 14:21:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment