Attention is currently required from: Cliff Huang, Furquan Shaikh, Sridhar Siricilla, Bernardo Perez Priego.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58126 )
Change subject: mb/google/brya: Add sub-regions to SI_ME in chromeos.fmd
......................................................................
Patch Set 18: Code-Review+1
(1 comment)
File src/mainboard/google/brya/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/58126/comment/c7d5c37b_1f711cde
PS18, Line 8: CSE_RW
Can CSE RW's starting offset be aligned @ 64K? This will help reducing the flashing time. […]
Good call Sridhar!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4da677da2e24b0398d04786e71490611db635ead
Gerrit-Change-Number: 58126
Gerrit-PatchSet: 18
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 21:12:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment