Attention is currently required from: Nicholas Chin.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )
Change subject: mb/lattepanda: Add support for LattePanda Mu ......................................................................
Patch Set 5:
(9 comments)
Patchset:
PS5: okay, I have been update to latest patch
File src/mainboard/lattepanda/mu/Kconfig:
https://review.coreboot.org/c/coreboot/+/83719/comment/c7a2276f_2c249b5f?usp... : PS4, Line 7: select BOARD_ROMSIZE_KB_16384 : select DRIVERS_INTEL_DPTF : select DRIVERS_UART_8250IO : select FSP_TYPE_IOT : select DRIVERS_SPI_ACPI : select DRIVERS_USB_ACPI : select HAVE_ACPI_RESUME : select HAVE_ACPI_TABLES : select HAVE_SPD_IN_CBFS : select INTEL_GMA_HAVE_VBT : select SOC_INTEL_ALDERLAKE_PCH_N : select SUPERIO_ITE_IT8613E
Nit: Sort alphabetically
Acknowledged
https://review.coreboot.org/c/coreboot/+/83719/comment/509a7a9b_fe5b9344?usp... : PS4, Line 27: int
Type not necessary as it's already defined in `console/Kconfig`
Acknowledged, okay remove the type
File src/mainboard/lattepanda/mu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83719/comment/0f75a671_21326615?usp... : PS4, Line 1:
Remove empty line 1
Okay, latest patch remove the empty line
https://review.coreboot.org/c/coreboot/+/83719/comment/cecba857_f49f8f10?usp... : PS4, Line 18: void bootblock_mainboard_init(void) : { : }
Can be removed if not used, as there is a weak implementation defined in `lib/bootblock. […]
Acknowledged, latest patch remove the unused function
File src/mainboard/lattepanda/mu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83719/comment/3b3c4492_fb9c8583?usp... : PS4, Line 1:
Remove empty line 1
Acknowledged, re-factory the file
https://review.coreboot.org/c/coreboot/+/83719/comment/1203fe5a_52538656?usp... : PS4, Line 242: device ref ipu off end
Already set to off in chipset devicetree, can be removed.
Acknowledged
https://review.coreboot.org/c/coreboot/+/83719/comment/dbc2a02a_3bd0022d?usp... : PS4, Line 251: device ref heci1 on end
Already set to on in chipset devicetree, can be removed.
Acknowledged
https://review.coreboot.org/c/coreboot/+/83719/comment/8b2a5e60_7580d46c?usp... : PS4, Line 252: device ref sata off end : device ref i2c5 off end
Same as chipset devicetree, remove
Acknowledged