Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85745?usp=email )
Change subject: mb/google/corsola: refactor mipi_panel_power_on function
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/corsola/panel_starmie.c:
https://review.coreboot.org/c/coreboot/+/85745/comment/49b2e8f8_eeef57cd?usp... :
PS4, Line 14: struct mipi_panel_config config = {
: .en_gpio = GPIO_EN_PP3300_DISP_X,
: .sync_gpio = GPIO_EN_PP3300_SDBRDG_X,
: };
: tps65132s_power_on(&config);
Instead of creating a new struct, we can declare `struct tps65132s_cfg` here and fill `struct tps65132s_reg_setting` in `tps65132s_power_on()`.
File src/mainboard/google/corsola/panel_tps65132s.c:
https://review.coreboot.org/c/coreboot/+/85745/comment/e8c2b126_d93f8320?usp... :
PS4, Line 29: PMIC_I2C_BUS
cfg->i2c_bus
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0561e57d99ab55e6dcbb7744b2228c4cebb0d88
Gerrit-Change-Number: 85745
Gerrit-PatchSet: 4
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 24 Dec 2024 02:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No