Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42426 )
Change subject: sb/intel/i82801gx,ix,jx: Drop invalid GNVS update routine
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42426/4/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42426/4/src/southbridge/intel/i8280...
PS4, Line 26: /* WAS BROKEN */
What's the purpose here: is that a TODO that the function needs to be filled in with a correct imple […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I407b9b9fd44db027a62356e2470f6c39ed3bff49
Gerrit-Change-Number: 42426
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 14:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment