[S] Change in coreboot[main]: soc/mediatek/mt8196: Add pwrsel driver

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85613?usp=email )

Change subject: soc/mediatek/mt8196: Add pwrsel driver
......................................................................

Patch Set 2:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85613/comment/d64dbff1_24d19045?usp... :
PS1, Line 9:
> is

Done

File src/mainboard/google/rauru/romstage.c:

PS1:
> Move to a separate patch.

Done

File src/soc/mediatek/mt8196/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/85613/comment/81ca81bf_28389e74?usp... :
PS1, Line 33: romstage-y += mtk_pwrsel.c
> Move to line 36

Done

File src/soc/mediatek/mt8196/include/soc/mtk_pwrsel.h:

https://review.coreboot.org/c/coreboot/+/85613/comment/4f13484f_a7c1ad89?usp... :
PS1, Line 8: 0x0
> One more tab to align with `0x04A4` below.

Done

File src/soc/mediatek/mt8196/mtk_pwrsel.c:

https://review.coreboot.org/c/coreboot/+/85613/comment/5ae8a4d2_3b5b829f?usp... :
PS1, Line 15: (
> remove

Done

https://review.coreboot.org/c/coreboot/+/85613/comment/32a9a63a_f6117913?usp... :
PS1, Line 22: printk(BIOS_INFO, "PWR_SEL = %#x\n",
            : 	       read32p(MCUSYS_BASE + OFFSET_PWRSEL));
> one line ?

Done

https://review.coreboot.org/c/coreboot/+/85613/comment/84408dfd_bd537e19?usp... :
PS1, Line 24: printk(BIOS_INFO, "PWRSEL_CONFIG = %#x\n",
            : 	       read32p(MFG_VCORE_AO_RPC_PWRSEL_CONFIG));
> ditto

Done