Attention is currently required from: Karthik Ramasubramanian, Shelley Chen.
Kun Liu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/84412?usp=email )
Change subject: mb/google/brox/var/lotso: Fix goodix touchscreen power off sequence
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84412/comment/8bb62e29_b02c03bb?usp... :
PS2, Line 9: Power off does not seem to use the ACPI _OFF function
Did you try to use "has_power_resource" = "1" in the concerned touchscreen device in the override tr […]
use "has_power_resource" = "1",add reset delay does not take effect,the result is as follows:https://partnerissuetracker.corp.google.com/issues/364193909#comment21, so use SMI handler to manage the power.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84412?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0108be4e5e7c0265aae0f16fd4e2b7cbe5936112
Gerrit-Change-Number: 84412
Gerrit-PatchSet: 2
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 01:21:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com