Attention is currently required from: Alexander Couzens, Patrick Rudolph. Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49253 )
Change subject: [WIP] pc80/rtc/option: Move register backup for SMI ......................................................................
[WIP] pc80/rtc/option: Move register backup for SMI
Change-Id: I025e9952a949834755f5cbc3dfe7b26ab9aaa032 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/lenovo/x60/smihandler.c M src/soc/intel/broadwell/pch/smihandler.c M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/lynxpoint/smihandler.c 4 files changed, 0 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/49253/1
diff --git a/src/mainboard/lenovo/x60/smihandler.c b/src/mainboard/lenovo/x60/smihandler.c index b5889db..a1b50b4 100644 --- a/src/mainboard/lenovo/x60/smihandler.c +++ b/src/mainboard/lenovo/x60/smihandler.c @@ -18,18 +18,11 @@ static void mainboard_smi_save_cmos(void) { u8 val; - u8 tmp70, tmp72; - - tmp70 = inb(0x70); - tmp72 = inb(0x72);
val = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4); set_option("tft_brightness", &val); val = ec_read(H8_VOLUME_CONTROL); set_option("volume", &val); - - outb(tmp70, 0x70); - outb(tmp72, 0x72); }
int mainboard_io_trap_handler(int smif) diff --git a/src/soc/intel/broadwell/pch/smihandler.c b/src/soc/intel/broadwell/pch/smihandler.c index 3a54749..abad5cd 100644 --- a/src/soc/intel/broadwell/pch/smihandler.c +++ b/src/soc/intel/broadwell/pch/smihandler.c @@ -128,14 +128,7 @@ static int power_on_after_fail(void) { u8 s5pwr = CONFIG_MAINBOARD_POWER_FAILURE_STATE; - - /* save and recover RTC port values */ - u8 tmp70, tmp72; - tmp70 = inb(0x70); - tmp72 = inb(0x72); get_option(&s5pwr, "power_on_after_fail"); - outb(tmp70, 0x70); - outb(tmp72, 0x72); return (s5pwr == MAINBOARD_POWER_ON); }
diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index 90d2f7a..b5e4729 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -96,14 +96,7 @@ static int power_on_after_fail(void) { u8 s5pwr = CONFIG_MAINBOARD_POWER_FAILURE_STATE; - - /* save and recover RTC port values */ - u8 tmp70, tmp72; - tmp70 = inb(0x70); - tmp72 = inb(0x72); get_option(&s5pwr, "power_on_after_fail"); - outb(tmp70, 0x70); - outb(tmp72, 0x72); return (s5pwr == MAINBOARD_POWER_ON); }
diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index 948e216..03c39d9 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -79,14 +79,7 @@ static int power_on_after_fail(void) { u8 s5pwr = CONFIG_MAINBOARD_POWER_FAILURE_STATE; - - /* save and recover RTC port values */ - u8 tmp70, tmp72; - tmp70 = inb(0x70); - tmp72 = inb(0x72); get_option(&s5pwr, "power_on_after_fail"); - outb(tmp70, 0x70); - outb(tmp72, 0x72); return (s5pwr == MAINBOARD_POWER_ON); }