Attention is currently required from: Reka Norman, Sumeet R Pawnikar, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75681?usp=email )
Change subject: mb/google/dedede/var/dibbi: Update power limits
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/dedede/variants/dibbi/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75681/comment/a23afea6_285b0d3e :
PS9, Line 16: 6000
In devicetree this is set to 3000. […]
Removed.
https://review.coreboot.org/c/coreboot/+/75681/comment/25e719fd_10aa6f4d :
PS9, Line 66: variant_update_cpu_power_limits(pwr_limits, total_entries);
Did you test this? It's not working for me because the common code uses `DEV_PTR(dptf_policy)` which […]
Update new code to review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75681?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6
Gerrit-Change-Number: 75681
Gerrit-PatchSet: 10
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chia-Ling Hou
chia-ling.hou@intel.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 07:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment