Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72690 )
Change subject: soc/amd/cezanne/reset: deduplicate code
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
i guess that this one won't be needed after CB:72659, so should i abandon this one?
That seems reasonable to me.
File src/soc/amd/cezanne/reset.c:
https://review.coreboot.org/c/coreboot/+/72690/comment/d11cd061_b220194f
PS1, Line 21: do_cold_reset();
hm, not sure
I don't think so - I can't think of a situation where that would really be useful. If we wanted to do something like that we could add a print when we set all reboots to cold just to note that you can't do warm resets on these platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3fe010a2b361ae9a1befeb4f07b12a80d978460
Gerrit-Change-Number: 72690
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Feb 2023 15:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment