Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36087/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36087/8//COMMIT_MSG@9 PS8, Line 9: Clone entirely from Icelake
So, since large commits result in large technical debt, what could be done instead? For example: how about breaking down the introduction of a new SoC more like the SoC itself is structured? For example, a commit could add TGL SATA support, another one could add TGL SMBus, another one, TGL UART support... These commits would be of a reasonable size to be reviewed effectively, which would make mistakes easier to spot.
This is reasonable feedback but what do we copy those TGL specific CLs like u told (SATA, SMBS, UART) into which SOC directory ? ICL ?
I know, the structure for a new SoC is more or less the same so it makes sense to copy an older one to start off, but this doesn't mean that a commit for the copy should be created.
creating new soc always been copy from "n-1" and maintain "n" with new and dedicated changes but having said that there might be considerable amount of same code. this was the motivation for us to create the common code v1.0 and we are looking at other possibility now to reduce those code.
-
Subrata Banik (Code Review)