HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43956 )
Change subject: src/acpi: Add missing <{stdbool,stdint}.h> ......................................................................
src/acpi: Add missing <{stdbool,stdint}.h>
Change-Id: Ic09c04cfa18408c61d7e99ea29bccc23acbd7144 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpigen_dptf.c M src/acpi/acpigen_ps2_keybd.c 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/43956/1
diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index 0c44b8f..26e0253 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -2,6 +2,8 @@
#include <acpi/acpigen.h> #include <acpi/acpigen_dptf.h> +#include <stdbool.h> +#include <stdint.h>
/* Defaults */ #define DEFAULT_RAW_UNIT "ma" diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index b14bbd2..be20220 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -5,6 +5,8 @@ #include <acpi/acpigen_ps2_keybd.h> #include <console/console.h> #include <input-event-codes.h> +#include <stdbool.h> +#include <stdint.h>
#define KEYMAP(scancode, keycode) (((uint32_t)(scancode) << 16) | (keycode & 0xFFFF)) #define SCANCODE(keymap) ((keymap >> 16) & 0xFFFF)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43956 )
Change subject: src/acpi: Add missing <{stdbool,stdint}.h> ......................................................................
Patch Set 1: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/43956/1/src/acpi/acpigen_dptf.c File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/43956/1/src/acpi/acpigen_dptf.c@433 PS1, Line 433: bool stdbool
https://review.coreboot.org/c/coreboot/+/43956/1/src/acpi/acpigen_dptf.c@445 PS1, Line 445: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43956/1/src/acpi/acpigen_ps2_keybd.... File src/acpi/acpigen_ps2_keybd.c:
https://review.coreboot.org/c/coreboot/+/43956/1/src/acpi/acpigen_ps2_keybd.... PS1, Line 206: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43956/1/src/acpi/acpigen_ps2_keybd.... PS1, Line 208: bool stddef
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43956 )
Change subject: src/acpi: Add missing <{stdbool,stdint}.h> ......................................................................
src/acpi: Add missing <{stdbool,stdint}.h>
Change-Id: Ic09c04cfa18408c61d7e99ea29bccc23acbd7144 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43956 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/acpi/acpigen_dptf.c M src/acpi/acpigen_ps2_keybd.c 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index b3cc37a..3877daa 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -2,6 +2,8 @@
#include <acpi/acpigen.h> #include <acpi/acpigen_dptf.h> +#include <stdbool.h> +#include <stdint.h>
/* Defaults */ #define DEFAULT_RAW_UNIT "ma" diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index b14bbd2..be20220 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -5,6 +5,8 @@ #include <acpi/acpigen_ps2_keybd.h> #include <console/console.h> #include <input-event-codes.h> +#include <stdbool.h> +#include <stdint.h>
#define KEYMAP(scancode, keycode) (((uint32_t)(scancode) << 16) | (keycode & 0xFFFF)) #define SCANCODE(keymap) ((keymap >> 16) & 0xFFFF)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)