[S] Change in libgfxinit[main]: gfxtest: Handle 64-bit aperture base - coreboot-gerrit

22 Jul 2024


      Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83597?usp=email )
Change subject: gfxtest: Handle 64-bit aperture base
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File gfxtest/hw-gfx-gma-gfx_test.adb:
https://review.coreboot.org/c/libgfxinit/+/83597/comment/af557f3d_9f85a646?u... :
PS1, Line 318: GMA_Phys_Base_Index
Why was `Config.GMA_Phys_Base_Index` not used here? I guess some oversight, but might be worth a sentence in the commit message.
-- 
To view, visit https://review.coreboot.org/c/libgfxinit/+/83597?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I4c92190719bd2a066f77061a86b38faa59c6dfb8
Gerrit-Change-Number: 83597
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:25:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes