Change in coreboot[master]: cbfs: Remove deprecated APIs

[Werner Zeh (Code Review)]

Attention is currently required from: Christian Walter, Julius Werner.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59682 )

Change subject: cbfs: Remove deprecated APIs
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> Thank you for driving this topic. […]

I did one additional comparison. Same code base but now with TPM_MEASURED_BOOT disabled. Looks like the immense time addon is caused by the hashing in your changed code?

Timestamps upstream without TPM_MEASURED_BOOT:
39 entries total:

0:1st timestamp                                     36,202
  11:start of bootblock                                46,989 (10,787)
  12:end of bootblock                                  73,778 (26,788)
  13:starting to load romstage                         73,796 (17)
  14:finished loading romstage                         74,858 (1,062)
   1:start of romstage                                 75,225 (367)
 970:loading FSP-M                                     101,660 (26,435)
   2:before RAM initialization                         102,602 (941)
 950:calling FspMemoryInit                             108,950 (6,348)
 951:returning from FspMemoryInit                      407,530 (298,580)
   3:after RAM initialization                          417,027 (9,497)
   4:end of romstage                                   428,575 (11,547)
 100:start of postcar                                  439,632 (11,056)
 101:end of postcar                                    439,632 (0)
   8:starting to load ramstage                         439,634 (2)
  15:starting LZMA decompress (ignore for x86)         439,644 (9)
  16:finished LZMA decompress (ignore for x86)         475,569 (35,925)
   9:finished loading ramstage                         475,676 (106)
  10:start of ramstage                                 486,026 (10,350)
  17:starting LZ4 decompress (ignore for x86)          486,350 (324)
  18:finished LZ4 decompress (ignore for x86)          529,279 (42,928)
  30:device enumeration                                541,823 (12,544)
 971:loading FSP-S                                     548,422 (6,598)
 954:calling FspSiliconInit                            548,435 (12)
 955:returning from FspSiliconInit                     583,828 (35,393)
  40:device configuration                              726,938 (143,110)
 956:calling FspNotify(AfterPciEnumeration)            731,768 (4,829)
 957:returning from FspNotify(AfterPciEnumeration)     731,970 (202)
  50:device enable                                     731,972 (1)
  60:device initialization                             743,968 (11,995)
  70:device setup done                                 774,833 (30,864)
  75:cbmem post                                        774,842 (8)
  80:write tables                                      778,083 (3,241)
  85:finalize chips                                    783,681 (5,598)
  90:starting to load payload                          785,359 (1,677)
 958:calling FspNotify(ReadyToBoot)                    3,123,687 (2,338,328)
 959:returning from FspNotify(ReadyToBoot)             3,124,350 (663)
 960:calling FspNotify(EndOfFirmware)                  3,124,351 (0)
 961:returning from FspNotify(EndOfFirmware)           3,125,237 (885)
  99:selfboot jump                                     3,125,343 (106)

Total Time: 3,089,123

Timestamps with this CL on top of upstream without TPM_MEASURED_BOOT:

39 entries total:

0:1st timestamp                                     36,114
  11:start of bootblock                                46,629 (10,514)
  12:end of bootblock                                  72,828 (26,198)
  13:starting to load romstage                         72,845 (17)
  14:finished loading romstage                         73,892 (1,046)
   1:start of romstage                                 74,237 (344)
 970:loading FSP-M                                     100,694 (26,457)
   2:before RAM initialization                         101,702 (1,007)
 950:calling FspMemoryInit                             107,963 (6,261)
 951:returning from FspMemoryInit                      406,509 (298,545)
   3:after RAM initialization                          415,969 (9,460)
   4:end of romstage                                   427,533 (11,563)
 100:start of postcar                                  438,590 (11,056)
 101:end of postcar                                    438,590 (0)
   8:starting to load ramstage                         438,592 (2)
  15:starting LZMA decompress (ignore for x86)         438,657 (64)
  16:finished LZMA decompress (ignore for x86)         474,701 (36,044)
   9:finished loading ramstage                         474,889 (187)
  10:start of ramstage                                 485,248 (10,359)
  17:starting LZ4 decompress (ignore for x86)          485,498 (250)
  18:finished LZ4 decompress (ignore for x86)          528,204 (42,705)
  30:device enumeration                                540,189 (11,985)
 971:loading FSP-S                                     546,787 (6,597)
 954:calling FspSiliconInit                            546,800 (13)
 955:returning from FspSiliconInit                     581,997 (35,196)
  40:device configuration                              716,986 (134,988)
 956:calling FspNotify(AfterPciEnumeration)            721,822 (4,835)
 957:returning from FspNotify(AfterPciEnumeration)     722,095 (273)
  50:device enable                                     722,097 (1)
  60:device initialization                             734,086 (11,988)
  70:device setup done                                 764,961 (30,875)
  75:cbmem post                                        764,969 (8)
  80:write tables                                      768,208 (3,238)
  85:finalize chips                                    773,804 (5,595)
  90:starting to load payload                          775,470 (1,666)
 958:calling FspNotify(ReadyToBoot)                    3,110,657 (2,335,186)
 959:returning from FspNotify(ReadyToBoot)             3,111,320 (662)
 960:calling FspNotify(EndOfFirmware)                  3,111,320 (0)
 961:returning from FspNotify(EndOfFirmware)           3,112,194 (873)
  99:selfboot jump                                     3,112,300 (106)

Total Time: 3,076,164