Attention is currently required from: Angel Pons, Arthur Heymans, Maximilian Brune, Nico Huber.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64184?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: haswell NRI: Initialise MPLL
......................................................................
Patch Set 5:
(1 comment)
File src/northbridge/intel/haswell/native_raminit/init_mpll.c:
https://review.coreboot.org/c/coreboot/+/64184/comment/5cb6abbb_953eabf3 :
PS5, Line 155: if (!ctrl->qclkps) {
i wonder what this if statement is for, since qclkps will only be set after the while loop. only had a brief look and didn't look at the patches after this one, so maybe i'm missing something here, but it at least seems to be unexpected
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64184?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I978c352de68f6d8cecc76f4ae3c12daaf4be9ed6
Gerrit-Change-Number: 64184
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 18 Apr 2024 19:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment