[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)

[Paul Menzel (Code Review)]

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh, Jan Samek.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 )

Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
......................................................................

Patch Set 12:

(6 comments)

File src/drivers/i2c/pi608gp/pi608gp.h:

https://review.coreboot.org/c/coreboot/+/74433/comment/a565ad91_2ab97501 
PS12, Line 10: #define DEEMPH_LVL_MV(_LVL, _LVL_10)	{.lvl = _LVL, .lvl_10 = _LVL_10}
Add spaces after { and before }?

File src/drivers/i2c/pi608gp/pi608gp.c:

https://review.coreboot.org/c/coreboot/+/74433/comment/3ec4b4bf_58b7666d 
PS12, Line 17: /* Only some of the available registers are implemented.
             :    For a full list, see the PI7C9X2G608GP datasheet. */
As it’s not in a function body you could use:

/*
     * […]
     */

https://review.coreboot.org/c/coreboot/+/74433/comment/ecf9b76a_be4fa8a3 
PS12, Line 26: level
Add the unit to the name?

https://review.coreboot.org/c/coreboot/+/74433/comment/b53cd293_d155f7f1 
PS12, Line 48: {  0, 0}
Use spaces consistently?

https://review.coreboot.org/c/coreboot/+/74433/comment/8aaad4fb_87d21b6a 
PS12, Line 54: uint8_t
Please use int [1]?

[1]: https://notabs.org/coding/smallIntsBigPenalty.htm

https://review.coreboot.org/c/coreboot/+/74433/comment/cc4c6ebe_e74c8e1f 
PS12, Line 71: /* Compose the SMBus message for register read init operation (from MSB to LSB):
             : 	   Byte 1: 7:3 = Rsvd., 2:0 = Command,
             : 	   Byte 2: 7:4 = Rsvd., 3:0 = Port Select[4:1],
             : 	   Byte 3: 7 = Port Select[0], 6 = Rsvd., 5:2 = Byte Enable, 1:0 = Reg. Addr. [11:10],
             : 	   Byte 4: 7:0 = Reg. Addr.[9:2] (Reg. Addr. [1:0] fixed to 0). */
Maybe use non-concise form?